Re: trying to update qscan patch for svn

[Kris Katterjohn <katterjohn () gmail com>]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

DePriest, Jason R. wrote:
> I am working with svn revision 9179.
>
> I have attached the updated patch for qscan and I am pasting below the
> error I get during 'make'.
>
> make[1]: Entering directory `/home/depriest/nmap-svn/nmap'
> g++ -c -Iliblua -Ilibdnet-stripped/include -Ilibpcre  -Inbase
> -Insock/include -g -O2 -Wall  -fno-strict-aliasing   -DHAVE_CONFIG_H
> -DNMAP_NAME=\"Nmap\" -DNMAP_URL=\"http://nmap.org\";
> -DNMAP_PLATFORM=\"i686-pc-linux-gnu\"
> -DNMAPDATADIR=\"/usr/local/share/nmap\"
> -DNMAPLIBEXECDIR=\"/usr/local/libexec/nmap\" nmap.cc -o nmap.o
> g++ -c -Iliblua -Ilibdnet-stripped/include -Ilibpcre  -Inbase
> -Insock/include -g -O2 -Wall  -fno-strict-aliasing   -DHAVE_CONFIG_H
> -DNMAP_NAME=\"Nmap\" -DNMAP_URL=\"http://nmap.org\";
> -DNMAP_PLATFORM=\"i686-pc-linux-gnu\"
> -DNMAPDATADIR=\"/usr/local/share/nmap\"
> -DNMAPLIBEXECDIR=\"/usr/local/libexec/nmap\" service_scan.cc -o
> service_scan.o
> g++ -c -Iliblua -Ilibdnet-stripped/include -Ilibpcre  -Inbase
> -Insock/include -g -O2 -Wall  -fno-strict-aliasing   -DHAVE_CONFIG_H
> -DNMAP_NAME=\"Nmap\" -DNMAP_URL=\"http://nmap.org\";
> -DNMAP_PLATFORM=\"i686-pc-linux-gnu\"
> -DNMAPDATADIR=\"/usr/local/share/nmap\"
> -DNMAPLIBEXECDIR=\"/usr/local/libexec/nmap\" qscan.cc -o qscan.o
> tcpip.h: In function 'void qscan_run()':
> tcpip.h:718: error: too few arguments to function 'char*
> readip_pcap(pcap_t*, unsigned int*, long int, timeval*, link_header*,
> bool)'
> qscan.cc:259: error: at this point in file
> make[1]: *** [qscan.o] Error 1
> make[1]: Leaving directory `/home/depriest/nmap-svn/nmap'
> make: *** [all] Error 2
>
> Can anyone see a blatant error?

I changed readip_pcap() to take another argument for doing packet validity
checking[1].  Michael was on the right track: either pass true or false for
the last argument depending on whether you want these checks done or not.

I didn't try to compile with this change, so if you have any other problems,
just shoot us another email.

> I don't write code for a living so my skills are limited.

I'm not quite to the writing-code-for-a-living stage, but I assume it'll be
coming up eventually... :)

> Thanks!
>
> -Jason

Thanks,
Kris Katterjohn

[1] http://seclists.org/nmap-dev/2008/q2/0908.html


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQIVAwUBSI/fbv9K37xXYl36AQKl2BAAtaG+RCVGG/QvPGfOU34SHciyrF77eBTR
oEEx8v+TrQZNe9wydU16VXzvdbmgZ9914OMQNXAqM/aq1DRCNqKhNyKUGzu1BvRJ
xohd8NplI8nJg94DBTZI3dONIQc1pvxP0tj9NeBHJEWDVn4+jhVlIjfIO6icPgat
hYlJ9WBpq1VNV5+kpgYuOe+IBbYHGH82cXTkseN02Tsa5EI2wjYsW+f57G9GVWun
xf5WgLdNVOfCKaGZNxza+wl4oQJhuuo9PbFJUbHsy6EkjbwCrctxHH/WKv+n3+lZ
G0f34/DIiKR3AGbx2EN4zuyPc55QlhzXLKDdu48cOaeqqw/P3K7BwRf7lziXhuIm
dO3F8TPyCC7oQZNyoI2qahVEbrdLVh8Zd+xZ8FZFqu/bQP6oZHECQhQqhJbO6Nee
TR5zWifDEyOanJ1DsnZfE9ZRb2EBosg51qAshe4dsmQvFCy16EBUeyCJV19/dQYZ
mPMljDHfZSLstJZmNXHdjdck+6gcNebR3yoklCMsj4yGXexQ3B8XyFL/UqBfStor
h8eP1Xs16He566TB+OrLPT93TBZFQOzQNm2NezJp79M+QHtuXEPqvu96U8MUXGoR
86Tg+AlqNq8Kbsq6AZtmjcr8oheKGEqqRU8AkKRybh4HoyE+JiCe+pOJodPtQqZb
9N7exa78xXI=
=lWXe
-----END PGP SIGNATURE-----

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org