Re: [RFC] Username/Password NSE library

["Patrick Donnelly" <batrick.donnelly () gmail com>]

On Wed, Jun 25, 2008 at 12:25 AM, Kris Katterjohn <katterjohn () gmail com> wrote:
> My initial reactions:
>
> * I mentioned the functionality of returning a table of usernames and
> passwords, and the option of returning a table of only a certain size,

Like I said, you can modify usernames and passwords to return smaller
tables based on a parameter (e.g. unpwdb.usernames("short")).
Alternatively, you can modify the design to operate on an array (and
use ipairs()). The user could then break on the number he wants e.g.:

for i, user in unpwdb.usernames() do
  if i > 20 then break; end
  -- do stuff
end

> * The third return value from the functions, which tells the caller whether
> we're using a user-defined list or not, is always nil in yours.

This is simply necessary for Lua's generic for loop and the next
function. I suggest alternate functions that return information about
it being a user-defined list and what not.

> Aside from these, your changes seem to work fine after I modified my test
> script to handle them.

Good to hear it.

Cheers,

-- 
-Patrick Donnelly

"One of the lessons of history is that nothing is often a good thing
to do and always a clever thing to say."

-Will Durant

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org