Re: [Patch] as a possible fix for minor presentational issue in nse_main.cc affecting script debugging output.

[Fyodor <fyodor () insecure org>]

On Tue, Mar 04, 2008 at 12:34:03AM +0000, jah wrote:
> whereas, when name resolution is permitted (and succeeds) the second of
> the above lines reads:
>
>     SCRIPT ENGINE: Script scanning some.hostname.com.
>
>
> The attached nse_main.cc.patch adds a check for an empty string for
> (*targets.begin())->HostName() and instead displays:
>
>     SCRIPT ENGINE: Script scanning 1 host.
>
> which seems in keeping with the behaviour seen with multiple targets and
> is the best I can do for now.

Hi Jah.  Thanks for your notes.  There is a function which gives the
hostname if available, otherwise the IP address.  That is probably
best to use here.

> Whilst I was looking at this issuette, I noticed that the Visual Studio
> solution for nmap doesn't show Target.h in it's list of header files
> (i.e there isn't an entry for it in nmap.vcproj).  It seems to make no
> difference whether it's added or not, but I thought I'd mention it.  I

Maybe it is used for dependency checking?  Or maybe it is just for
convenience of opening the files.  If you want to sync the .h files
with the vcproject files (remove the .h files which no longer exist
and add missing nmap .h files), and send me a patch against svn, that
would be great!

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org