Nmap Development mailing list archives

Re: [PATCH] Don't require ".nse" be passed to --script

From: Fyodor <fyodor () insecure org>
Date: Tue, 27 Nov 2007 19:24:35 -0800

On Fri, Nov 23, 2007 at 04:41:46PM +0100, Diman Todorov wrote:


I am not sure, the idea may have its merits. What do others think?

The only problem I am seeing is that this patch is a bit on the ugly  
side. I don't think that goto and that retried boolean are really  
necessary :)


Yeah, I agree that the goto is unnecessary.  But since nobody has
objected to this patch, I'm all for putting it in if Kris (or someone)
can lose the goto, document it in refguide.xml, and the patch is short
and easy to verify.  It is sort of a violation of the feature freeze,
but this will probably only take 5 new/changed lines or so, so it
shouldn't be very risky.

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org

Current thread:

[PATCH] Don't require ".nse" be passed to --script Kris Katterjohn (Nov 15)
- Re: [PATCH] Don't require ".nse" be passed to --script Diman Todorov (Nov 23)
  - Re: [PATCH] Don't require ".nse" be passed to --script Fyodor (Nov 27)