Re: [Exp PATCH] Consolidation bug in traceroute

[Kris Katterjohn <katterjohn () gmail com>]

Eddie Bell wrote:
> Off the top of my head I cannot see any problems. The only time that
> piece of code is envoked is when we are printing consolidated
> traceprobes. Your piece of code will never be envoked unless all
> probes have been consolidates, which is what we want.


Well, that's just it, right?


for (ttl_count = 1; ttl_count <= tg->hopDistance; ttl_count++) {

<snip>

/* If we cannot find a traceprobe we are probably still consolidating */
if ((it = tg->TraceProbes.find (ttl_count)) == tg->TraceProbes.end ())
   continue;

<snip>

}


This is how it goes in my head, before the patch (the code above):

[[[

Enter the for() with ttl_count == tg->hopDistance (last loop) and
consolidating everything

Test if we can find the traceprobe... no: 'continue;'

ttl_count is no longer <= tg->hopDistance, so the loop isn't executed...

..leaving no hop or consolidation output beside "1"

]]]


The problem is right there, isn't it? So the patch fixes it?

Or have you had output, before the patch, with a fully-consolidated
trace without this problem?

> I'll do some more scanning to see if i can test it
>
> thanks
> - eddie

Cool.

Thanks,
Kris Katterjohn

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org