Re: [PATCH] Add '__attribute__ ((format (printf, 1, 2)))' to nmapfe_error.h

[Fyodor <fyodor () insecure org>]

On Fri, Sep 22, 2006 at 02:23:03PM -0500, Kris Katterjohn wrote:
> The attached patch adds "__attribute__ ((format (printf, 1, 2)))" to the
> error functions in nmapfe_error.h like the ones in nmap_error.h.

Thanks, applied.

> Also, nmap_error.h needs to have the same "#ifndef __attribute__" as
> nmapfe_error.h (in patch) and NmapOutputTable.h does, but I didn't know
> whether you'd prefer #including NmapOutputTable.h or adding another
> #ifndef to nmap_error.h.

I usually just let nbase handle it (nbase/nbase.h has the define).

> The attached patch uses geteuid() instead of getuid() when checking
> privileges, and changes 'guint uid' to 'gboolean isr00t' for testing
> root privileges because IMO it's simpler and more like the "core" nmap.

Thanks, applied.

Cheers,
-F

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org