Nmap Development mailing list archives

[PATCH] Fix small "code typo" in parseArp() in tcpip.cc


From: Kris Katterjohn <kjak () ispwest com>
Date: Wed, 13 Sep 2006 19:49:27 -0500

The attached patch uses sizeof on the correct variable in parseArp() in
tcpip.cc. It's not causing any errors because 'who_has' and 'tell' are
the same size.

It's a diff against 4.20ALPHA6 (but applies cleanly to ALPHA7)

Thanks,
Kris Katterjohn
--- x/tcpip.cc  2006-08-28 22:26:10.000000000 -0500
+++ y/tcpip.cc  2006-09-11 22:59:48.000000000 -0500
@@ -248,7 +248,7 @@ void PacketTrace::traceArp(pdirection pd
 
   if (frame[21] == 1) /* arp REQUEST */ {
     inet_ntop(AF_INET, frame+38, who_has, sizeof(who_has));
-    inet_ntop(AF_INET, frame+28, tell, sizeof(who_has));
+    inet_ntop(AF_INET, frame+28, tell, sizeof(tell));
     snprintf(arpdesc, sizeof(arpdesc), "who-has %s tell %s", who_has, tell);
   } else { /* ARP REPLY */
     inet_ntop(AF_INET, frame+28, who_has, sizeof(who_has));

_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev
Archived at http://SecLists.Org

Current thread: