Re: Quick patch for Intel-based Macintosh

[Andy Lutomirski <luto () stanford edu>]

On 1/25/06, Fyodor <fyodor () insecure org> wrote:
> On Wed, Jan 25, 2006 at 12:05:13AM -0800, Kurt Grutzmacher wrote:
> > --- nmap-3.98BETA1/tcpip.cc     2006-01-22 13:50:10.000000000 -0800
> > +++ nmap-3.98BETA1-grutz/tcpip.cc       2006-01-24 22:26:25.000000000
> > -0800
> > @@ -987,7 +987,7 @@
> >        must deal with it here rather than when building the packet,
> >        because they should be in NBO when I'm sending over raw
> >        ethernet */
> > -#if FREEBSD || BSDI || NETBSD || DEC
> > +#if FREEBSD || BSDI || NETBSD || DEC || MACOSX
> >     ip->ip_len = ntohs(ip->ip_len);
> >     ip->ip_off = ntohs(ip->ip_off);
> > #endif
>
> Thanks.  Breaking Mac OS X PPC to fix Mac OS X Intel wouldn't really
> be a net win (if this patch does indeed break PPC).


I don't have a Mac, but this appears perfectly safe, as (unless I'm grossly
mistaken), PPC is big-endian and ntohs is a no-op.

--Andy



o Any Mac OS X PPC users out there willing to test with this patch and
>   see if it still works?
>
> o Any other Mac OS X Intel users who can test without the patch
> (report wither base Nmap 3.98BETA1 works or not), then apply the patch
> and 'make clean;make' and test (and report back to nmap-dev) whether
> it works with the patch.  That certainly would be useful, as I would
> like Nmap 4.0 to work with Mac OS X Intel.
>
> Thanks,
> Fyodor
>
>
> _______________________________________________
> Sent through the nmap-dev mailing list
> http://cgi.insecure.org/mailman/listinfo/nmap-dev


_______________________________________________
Sent through the nmap-dev mailing list
http://cgi.insecure.org/mailman/listinfo/nmap-dev