Re: Windows build fails

[Gerald Combs <gerald () wireshark org>]

In my Windows VM I did the following:

- Opened "Visual Studio Installer".
- In the Visual Studio 2019 box, clicked "Modify".
- In the "Installation Details" list on the right, checked the highest-numbered SDK, which was "Windows 11 SDK 
(10.0.22000.0)" and made sure any other Windows SDKs were unchecked.
- Muttered under my breath about 2021 being 10 whole years after 2011 and maybe Microsoft should have added C11 support 
a long time ago.

On 12/17/21 2:11 PM, chuck c wrote:
> Any recommendations for upgrading the pieces for a "pet" build environment vs the CI/CD "cattle" method?
>
> https://www.wireshark.org/docs/wsdg_html/#_windows_platform_sdk 
> <https://www.wireshark.org/docs/wsdg_html/#_windows_platform_sdk>
> "4.5.5. Windows Platform SDK
> The Windows Platform SDK (PSDK) or Windows SDK is a free (as in beer) download and contains platform specific headers 
> and libraries (e.g. windows.h, WSock32.lib, etc.).
> As new Windows features evolve in time, updated SDKs become available that include new and updated APIs.
>
> When you purchase a commercial Visual Studio or use the Community Edition, it will include an SDK."
>
> C:\Development\wsbuild64>cmake -G "Visual Studio 16 2019" -A x64 ..\wireshark
> -- Selecting Windows SDK version 10.0.19041.0 to target Windows 10.0.19042.
> -- Generating build using CMake 3.19.8
> -- Using "Visual Studio 16 2019" generator (multi-config)
> -- LTO/IPO is not enabled
> -- Using 3rd party repository
> -- Building for win64 and CPU target amd64
> Working in W:\Development\wireshark-win64-libs
> Tag 2021-12-09 found. Skipping.
> -- V: 3.7.0-CDC_211217, MaV: 3, MiV: 7, PL: 0, EV: -CDC_211217.
> CMake Warning at CMakeLists.txt:593 (message):
>    Windows SDK 10.0.19041.0 doesn't support C11.  Please make sure you're
>    using 10.0.20348.0 or later.
>
> On Fri, Dec 17, 2021 at 3:15 AM Dario Lombardo <lomato () gmail com <mailto:lomato () gmail com>> wrote:
>
>     I've forced sdk 10.0.20348.0, and indeed it looks like cmake is using it.
>
>     https://github.com/crondaemon/wireshark/runs/4558028604?check_suite_focus=true 
> <https://github.com/crondaemon/wireshark/runs/4558028604?check_suite_focus=true>
>
>     However the error still persists. Any other hint?
>
>     On Thu, Dec 16, 2021 at 5:50 PM Gerald Combs <gerald () wireshark org <mailto:gerald () wireshark org>> wrote:
>
>         We recently added a requirement for C11, which requires a relatively recent Windows SDK. The build is failing 
> with
>
>         CMake Error at CMakeLists.txt:589 (message):
>             Windows SDK 10.0.17763.0 doesn't support C11.  Please make sure you're
>             using 10.0.20348.0 or later.
>
>         Is there any way to switch the GitHub builders to a newer Windows SDK?
>
>         On 12/16/21 3:31 AM, Dario Lombardo wrote:
>          > Hi
>          > The github windows builder is failing
>          >
>          > https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true 
> <https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true> 
> <https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true 
> <https://github.com/wireshark/wireshark/runs/4546222143?check_suite_focus=true>>
>          >
>          > It started to show up around a couple of days ago, around commit 77b6bca3870d5ef63303e637cc39e2cf83f49ddc, 
> as seen on
>          >
>          > https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster 
> <https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster> 
> <https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster 
> <https://github.com/wireshark/wireshark/actions/workflows/windows.yml?query=branch%3Amaster>>
>          >
>          > --
>          >
>          > Naima is online.
>          >
>          >
>          > ___________________________________________________________________________
>          > Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org <mailto:wireshark-dev () wireshark 
> org>>
>          > Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>          > Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 
> <https://www.wireshark.org/mailman/options/wireshark-dev>
>          >               mailto:wireshark-dev-request () wireshark org <mailto:wireshark-dev-request () wireshark 
> org>?subject=unsubscribe
>
>
>
>     -- 
>
>     Naima is online.
>
>     ___________________________________________________________________________
>     Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org <mailto:wireshark-dev () wireshark org>>
>     Archives: https://www.wireshark.org/lists/wireshark-dev <https://www.wireshark.org/lists/wireshark-dev>
>     Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev 
> <https://www.wireshark.org/mailman/options/wireshark-dev>
>                   mailto:wireshark-dev-request () wireshark org <mailto:wireshark-dev-request () wireshark 
> org>?subject=unsubscribe
>
>
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>               mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe