Re: Trouble uploading Wireshark enhancement

[Jaap Keuter <jaap.keuter () xs4all nl>]

> On 23 Oct 2020, at 04:21, Fulko Hew <fulko.hew () gmail com> wrote:
>
> I've enhanced a Lua based dissector, and have also rewritten it
> in 'C' so that it can be included in the next release of Wireshark.
>
> Now I'm trying to submit it.  My last submission was back in 2007,
> and things have changed a little since then.
>
> I believe? the latest doc on how to submit changes are in:
>
> https://gitlab.com/wireshark/wireshark/-/wikis/Development/SubmittingPatches#a-super-short-overview-of-git 
> <https://gitlab.com/wireshark/wireshark/-/wikis/Development/SubmittingPatches#a-super-short-overview-of-git>
>
> After being a developer for 45 years, I never had to use git until now, so I'll
> admit I don't know anything about git, and I'm trying to follow those instructions.
>
> I got to the point of 'commit' and then 'git push downstream +HEAD'
> and I get the error:
>
> fatal: 'downstream' does not appear to be a git repository
> fatal: Could not read from remote repository.
>
> Please make sure you have the correct access rights
> and the repository exists.
>
> What am I doing wrong?


Hi,

Indeed _a lot_ has changed over time, and we’re still shaking a little from the latest transition to GitLab. As a 
result the guidance and documentation is not yet settled. One of the things we as a group need to finalise is how we 
imagine the repository setup for developers to be. This is because in this case (i.e., with sites like GitLab and 
GitHub) you work with a ‘repository triangle’. This means you have the repo of the project (Wireshark), the 'fork' of 
the project on the web service's site, and your clone of the repo. Your clone of the repo can either be from the 
project repo, or from your forks repo. Either way, the repo you cloned from is referred to as ‘origin’. If you clone 
from the project repo you have no relation to your fork, in the web service. That is were you can add a remote for your 
clone, and this is imagined to be ‘downstream’. This is ‘somewhat’ described in the section ‘Migrating form Gerrit’ but 
that is also not completely suitable. As said the documentation is not yet settled. Anyway, depending on where you 
cloned from (project repo, or your clone), you can add a remote (downstream or upstream respectively) and use the name 
pointing to your clone to push to. 

Hope it makes sense,
Jaap

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe