Re: c-ares version not updated

[Pascal Quantin <pascal () wireshark org>]

Le mar. 10 déc. 2019 à 21:34, Pascal Quantin <pascal () wireshark org> a
écrit :

> Hi Chris,
>
> Le mar. 10 déc. 2019 à 17:39, Maynard, Chris via Wireshark-dev <
> wireshark-dev () wireshark org> a écrit :
>
> > There was a bug with the c-ares 1.15.0 release where the version wasn’t
> > updated.  As such, Wireshark’s “About Wireshark” shows 1.14.0 instead of
> > the proper 1.15.0 version.
> >
> > For example:
> >
> > 3.3.0 (v3.3.0rc0-114-gb098353ad9d3)
> >
> > Compiled (64-bit) with Qt 5.12.6, with WinPcap SDK (WpdPack) 4.1.2, with
> > GLib
> > 2.52.3, with zlib 1.2.11, with SMI 0.4.8, *with c-ares 1.14.0*, with Lua
> > 5.2.4,
> > with GnuTLS 3.6.3 and PKCS #11 support, with Gcrypt 1.8.3, with MIT
> > Kerberos,
> > with MaxMind DB resolver, with nghttp2 1.39.2, with brotli, with LZ4, with
> > Zstandard, with Snappy, with libxml2 2.9.9, with QtMultimedia, with
> > AirPcap,
> > with SpeexDSP (using bundled resampler), with SBC, with SpanDSP, with
> > bcg729.
> >
> > Running on 64-bit Windows 10 (1909), build 18363, with Intel(R) Xeon(R)
> > CPU
> > E3-1505M v5 @ 2.80GHz (with SSE4.2), with 16225 MB of physical memory,
> > with
> > locale English_United States.1252, with light display mode, without
> > HiDPI, with
> > Npcap version 0.9984, based on libpcap version 1.9.1, with GnuTLS 3.6.3,
> > with
> > Gcrypt 1.8.3, with brotli 1.0.2, with AirPcap 4.1.0 build 1622, binary
> > plugins
> > supported (19 loaded).
> >
> > Built using Microsoft Visual Studio 2019 (VC++ 14.24, build 28314).
> >
> > The bug was fixed upstream last year:
> > *https://github.com/c-ares/c-ares/pull/230*
> > <https://github.com/c-ares/c-ares/pull/230>.
> >
> > Should Wireshark update the ares_version.h header file to avoid
> > confusion about which version of c-ares Wireshark is built with?
>
> I just double checked the current vcpkg port and they fixed the header. So
> I'm gonna update our package.

After further investigation it appears that the current vcpkg port is not
1.15.0, but a snapshot from 2019-05-02 (
https://github.com/c-ares/c-ares/commit/9f1fdbf5dd633f81352fac0d6bc0d0c4d45be459)
so as to include support for ARM/ARM64. So we can either:
- use the current vcpkg port, but it will not be an official version (not
nice)
- manually rebuild 1.15.0 with
https://github.com/c-ares/c-ares/commit/000e963fff596d817d03f366cd49b1fd2d6ec961
that is the real 1.15.0 + fixed header + some android doc updated. I'm
gonna take this path.

Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe