Wireshark mailing list archives
Re: Master build broken for me (packet-http2.c)
From: Anders Broman <a.broman58 () gmail com>
Date: Fri, 28 Sep 2018 18:09:33 +0200
Hi, I think a patch to that effect has been committed. Regards Anders Den fre 28 sep. 2018 17:48Martin Mathieson via Wireshark-dev < wireshark-dev () wireshark org> skrev:
I am getting this build error: home/martin/wireshark/epan/dissectors/packet-http2.c: In function ‘http2_get_stream_id’: /home/martin/wireshark/epan/dissectors/packet-http2.c:1124:21: error: ‘http2_session_t’ has no member named ‘current_stream_id’ return h2session->current_stream_id; ^ /home/martin/wireshark/epan/dissectors/packet-http2.c:1125:1: error: control reaches end of non-void function [-Werror=return-type] } ^ cc1: all warnings being treated as errors Should http_get_stream_id just return 0 if HAVE_NGHTTP2 is not defined, or is it best not to even call it? Regards, Martin ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Master build broken for me (packet-http2.c) Martin Mathieson via Wireshark-dev (Sep 28)
- Re: Master build broken for me (packet-http2.c) Anders Broman (Sep 28)