Wireshark mailing list archives
Re: 2.5.0 release on January 16
From: Stig Bjørlykke <stig () bjorlykke org>
Date: Wed, 17 Jan 2018 20:37:25 +0100
On Wed, Jan 17, 2018 at 2:05 AM, Gerald Combs <gerald () wireshark org> wrote:
On 1/13/18 4:16 AM, Stig Bjørlykke wrote:- Qt: Missing string translations after source code was moved to utils/models/manager/widgets subdirectoriesDo you know what's missing? This shouldn't be too hard to fix.
I haven't investigated this, but I'm thinking that the generation of the *.ts files should also include the source subdirectories. The translations was lost just after the move to separate directories.
- ByteView: Hovering bytes does not highlight the field as it used to do - ByteView: Vertical white and horisontal black lines issues - ByteView: Color issue when clicking a byte multiple timesThe 2.4 byte view didn't distinguish between hovered and a locked bytes. I initially tried to do so by drawing an overline+undlerline over hovered bytes and coloring locked bytes. Change 25348 draws a full outline instead of an overline+undlerline.
The change makes this issues better. I'm still not sure about the "blue text on yellow background" when locked, this does not look so good with the macOS colour schemes. Maybe this could be changed to a red thicker outline? Or maybe use our "marked packet" colours? Or a combination. I never understood the white vertical lines, but now it seems like it's a bug when drawing the background colour. Have a look at the attached picture. When locking a byte the first time all bytes within a protocol has grey background colour but this grey background colour is not added on subsequent locks within the same protocol byte range. And selecting a byte does not expand the corresponding tree item as it does in 2.4. -- Stig Bjørlykke
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- 2.5.0 release on January 16 Gerald Combs (Jan 05)
- Re: 2.5.0 release on January 16 Stig Bjørlykke (Jan 06)
- Re: 2.5.0 release on January 16 Roland Knall (Jan 06)
- Re: 2.5.0 release on January 16 Anders Broman (Jan 08)
- Re: 2.5.0 release on January 16 Roland Knall (Jan 06)
- Re: 2.5.0 release on January 16 Stig Bjørlykke (Jan 13)
- Re: 2.5.0 release on January 16 Gerald Combs (Jan 16)
- Re: 2.5.0 release on January 16 Anders Broman (Jan 17)
- Re: 2.5.0 release on January 16 Alexis La Goutte (Jan 17)
- Re: 2.5.0 release on January 16 Stig Bjørlykke (Jan 17)
- Re: 2.5.0 release on January 16 Anders Broman (Jan 18)
- Re: 2.5.0 release on January 16 Pascal Quantin (Jan 18)
- Message not available
- Message not available
- Re: 2.5.0 release on January 16 Anders Broman (Jan 18)
- Re: 2.5.0 release on January 16 Gerald Combs (Jan 16)
- Re: 2.5.0 release on January 16 Stig Bjørlykke (Jan 06)