Wireshark mailing list archives
Re: Question about git style
From: Jaap Keuter <jaap.keuter () xs4all nl>
Date: Thu, 18 Jan 2018 19:09:12 +0100
On 07-01-18 22:36, Dario Lombardo wrote:
If I'm not mistaken, that is not requested. A draft change in gerrit is a change sent to the special branch refs/drafts/master. This is a real draft, that differs from a regular change for the fact that it's not visible to others, until it gets promoted to refs/for/master. A draft change can be reviewed, but this requires the author to manually add reviewers. A [WIP] change it's just a regular change, where the author is informing others that the change is not ready to merge. This is a common practice across projects and VCSes, but it's not enforced by anything on git/gerrit. Nothing prevents a [WIP] change to be merged. From my experience Wireshark developers do that to make the review process easier (for instance because petri dish can't be triggered on a draft change), allowing anyone interested in reviewing it on board. Dario.
Hi Dario, Maybe you can write something like this on https://wiki.wireshark.org/Development/SubmittingPatches to make this more well known. Thanks, Jaap ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Question about git style Craig Jackson (Jan 01)
- Re: Question about git style Roland Knall (Jan 01)
- Re: Question about git style Jaap Keuter (Jan 02)
- Re: Question about git style Craig Jackson (Jan 02)
- Re: Question about git style Jaap Keuter (Jan 18)
- Re: Question about git style Craig Jackson (Jan 18)
- Re: Question about git style Craig Jackson (Jan 02)
- Re: Question about git style Dario Lombardo (Jan 07)
- Re: Question about git style Jaap Keuter (Jan 18)
- Re: Question about git style Dario Lombardo (Jan 19)