Wireshark mailing list archives
Re: Making oui_base_custom available more generally
From: Roland Knall <rknall () gmail com>
Date: Sat, 19 Aug 2017 13:15:32 +0200
Which OUI are we talking about? Generally speaking, a wsutil/oui_handler.? could be useful, as for instance, openSAFETY uses OUI-24 as well. So it could be made the case, to move the OUI handling outside of the dissector and into a generic wsutil or epan structure. cheers, Roland On Sat, Aug 19, 2017 at 1:04 PM, Dario Lombardo <dario.lombardo.ml () gmail com
wrote:
I don't think that's enough. The linker should be able to resolve the symbol this way, but the compiler shouldn't. Then you'd have to declare it extern. But the right thing to do is to create a .h file that holds the public declaration of the .c file, and include it. This is a best practice generally speaking, and it's whas is done in wireshark as well. Have a look at packet-dns.c/h that do what you think. Moreover, there is already a file packet-ieee80211.h: that should be the place. Cheers, Dario. On Sat, Aug 19, 2017 at 4:14 AM, Richard Sharpe < realrichardsharpe () gmail com> wrote:Hi folks, I have a need to deal with OUIs in a dissector I am writing and find that it is defined as static void in packet_ieee80211.c. Should I simply remove static from that declaration, or should we promote it to some other file to make it generally available? -- Regards, Richard Sharpe (何以解憂?唯有杜康。--曹操) ____________________________________________________________ _______________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscr ibe____________________________________________________________ _______________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject= unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Making oui_base_custom available more generally Richard Sharpe (Aug 18)
- Re: Making oui_base_custom available more generally Dario Lombardo (Aug 19)
- Re: Making oui_base_custom available more generally Roland Knall (Aug 19)
- Re: Making oui_base_custom available more generally Michael Mann via Wireshark-dev (Aug 19)
- Re: Making oui_base_custom available more generally Alexis La Goutte (Aug 19)
- Re: Making oui_base_custom available more generally Michael Mann via Wireshark-dev (Aug 19)
- Re: Making oui_base_custom available more generally Richard Sharpe (Aug 19)
- Re: Making oui_base_custom available more generally Michael Mann via Wireshark-dev (Aug 19)
- Re: Making oui_base_custom available more generally Richard Sharpe (Aug 19)
- Re: Making oui_base_custom available more generally Michael Mann via Wireshark-dev (Aug 19)
- Re: Making oui_base_custom available more generally Richard Sharpe (Aug 19)
- Re: Making oui_base_custom available more generally Roland Knall (Aug 19)
- Re: Making oui_base_custom available more generally Dario Lombardo (Aug 19)