Wireshark mailing list archives
Re: dissectors update: create a branch or not?
From: Bertin Nicolas <nicolas.bertin () al-enterprise com>
Date: Mon, 3 Apr 2017 07:10:42 +0000
Hello Erik, Yes, I work off the main branch and I've checked that the patch is in. ________________________________ From: wireshark-dev-bounces () wireshark org <wireshark-dev-bounces () wireshark org> on behalf of Erik de Jong <erikdejong () gmail com> Sent: Friday, March 31, 2017 19:04 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] dissectors update: create a branch or not? On Fri, Mar 31, 2017 at 5:56 PM, Alexis La Goutte <alexis.lagoutte () gmail com<mailto:alexis.lagoutte () gmail com>> wrote: Hi Nicolas There is no really branch with Gerrit... You need to push direclty on master (and after fix it is bug fix, i will be backport to other branch) Cheers On Fri, Mar 31, 2017 at 5:43 PM, Bertin Nicolas <nicolas.bertin () al-enterprise com<mailto:nicolas.bertin () al-enterprise com>> wrote: Hi, I'm updating the dissectors of the protocols used by some of the Alcatel-Lucent Enterprise products (terminals and call servers). I've modified the source code (packet-noe.c and packet-noe3g.c) and tests are ongoing. When ready, I'd like to submit these patches for review. Hi Nicolas, please bear in mind that I've submitted a small patch with a fix for packet-noe.c recently, be sure to work off the main branch so that it's included. See https://code.wireshark.org/review/#/c/20633/ for the change. Now, after reading the Wiki, I'd like to know if I should create a branch to identify this work or if I can/should submit directly into the master? Thanks for your recommendations and advices. Regards, Nicolas ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org<mailto:wireshark-dev () wireshark org>> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org<mailto:wireshark-dev-request () wireshark org>?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org<mailto:wireshark-dev () wireshark org>> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org<mailto:wireshark-dev-request () wireshark org>?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: dissectors update: create a branch or not? Bertin Nicolas (Apr 03)