Wireshark mailing list archives
Re: Actualize kafka dissector
From: Jaap Keuter <jaap.keuter () xs4all nl>
Date: Mon, 14 Nov 2016 23:08:11 +0100
On 14-11-16 21:50, Dmitry Lazurkin wrote:
Sure you may.Thanks. Ok, i have some questions. First questions about supported and unsupported packet versions. Kafka packets have "API Version" field. I will try to show problem with example. Latest version of kafka server supports Produce Request/Response of version 0, 1, 2. Dissector parses correctly only 0 and 1. For Produce Response it generates incorrect proto tree because this version has new field in middle of packet. Current version parses incorrectly and doesn't add expert info. - Should dissector rejects packets with unsupported versions and add export info? - Or should dissector parse incorrectly (or correctly if format was not changed) and always add expert info about "Unsupported version: May be parsed incorrectly"? I like second solution.
Hi, If it doesn't cause too much confusion than yes, the second solution is fine. But if the protocol versions are totally different (think IPv4 vs. IPv6) than there's no use and the first solution is desirable. So, you can be the judge of that. Thanks, Jaap ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Actualize kafka dissector Dmitry Lazurkin (Nov 11)
- Re: Actualize kafka dissector Jaap Keuter (Nov 13)
- Re: Actualize kafka dissector Dmitry Lazurkin (Nov 14)
- Re: Actualize kafka dissector Jaap Keuter (Nov 14)
- Re: Actualize kafka dissector Dmitry Lazurkin (Nov 14)
- Re: Actualize kafka dissector Michael Mann (Nov 14)
- Re: Actualize kafka dissector Martin Mathieson (Nov 15)
- Re: Actualize kafka dissector Dmitry Lazurkin (Nov 15)
- Re: Actualize kafka dissector Jaap Keuter (Nov 15)
- Re: Actualize kafka dissector Martin Mathieson (Nov 15)
- Re: Actualize kafka dissector Dmitry Lazurkin (Nov 14)
- Re: Actualize kafka dissector Jaap Keuter (Nov 13)