Re: Where to add new SMB2 ioctl dissectors?

[Alexis La Goutte <alexis.lagoutte () gmail com>]

Hi Gordon,

If we want to add some value on smb2_ioctl_vals value_string, need to be
sorted.
This array/value_string use "binary tree" (for optimization stuff) and need
to be sorted

Cheers

On Fri, May 27, 2016 at 4:41 PM, Gordon Ross <gordon.w.ross () gmail com>
wrote:

> What's the convention on placement of new SMB2 ioctl dissectors?
> In the same order as the smb2_ioctl_vals[] array?
> Or new ones at the end?  (or whatever the submitter did? :)
>
> Thanks,
> Gordon
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe