Re: Latest libnghttp2 checkin broken

[Alexis La Goutte <alexis.lagoutte () gmail com>]

Hi Jorg,

On Fri, May 1, 2015 at 1:46 AM, Joerg Mayer <jmayer () loplof de> wrote:

> The latest checkin to libnghttp2 should not have happend:
> a) it breaks compilation on my system
>   /home/jmayer/work/wireshark/git/epan/nghttp2/nghttp2_hd.c: In function
> ‘hd_inflate_remove_bufs_with_name’:
> /home/jmayer/work/wireshark/git/epan/nghttp2/nghttp2_hd.c:1736:10: error:
> variable ‘rv’ set but not used [-Werror=unused-but-set-variable]
>    size_t rv;
>           ^
What compile and release do you using ?
Because before pushing, i have check with clang/gcc and also Visual Studio
(32 & 64 bits, Thanks Pascal)
I

> and
> b) it can only have been committed with --no-verify as it contains
> deprecated
>    functions (checkAPI.pl). I hit this during conflict resolution (git
> commit).
>
> pre-commit tools is no perfect... it is for help when commit code and
there is some false postive...


> Either we should remove the lib from the Wireshark source (an
> inconvenience as
> most distros don't provide packages for this) or the code needs to conform
> to
> Wireshark's development environment, i.e. it requires adaption and
> stricter testing
> than what seems to be happening right now.
After pushing, i have check and no buildbot fail...


> Ciao
>    Jörg
> --
> Joerg Mayer                                           <jmayer () loplof de>
> We are stuck with technology when what we really want is just stuff that
> works. Some say that should read Microsoft instead of technology.
> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe