Re: [Wireshark-commits] master 0b2c8b0: AMQP: fix declaration of 'index' shadows a global declaration

[Alexis La Goutte <alexis.lagoutte () gmail com>]

On Tue, Feb 3, 2015 at 6:50 AM, Guy Harris <guy () alum mit edu> wrote:

> On Feb 2, 2015, at 1:46 PM, Wireshark code review <
> code-review-do-not-reply () wireshark org> wrote:
>
> > 0b2c8b0 by Alexis La Goutte (alexis.lagoutte () gmail com):
> >
> >    AMQP: fix declaration of 'index' shadows a global declaration
> >
> >    St*** Mac OS X buildbot...
>
> It's probably Ken or Dennis's fault; the original name for The Routine
> Currently Known As strchr() was index(), perhaps by (weak) analogy to
> PL/I's index() function (which was more like strstr(), as I remember).  V7
> had index() and reindex(), as did the V7-based UNIX/32V and the
> UNIX/32V-derived 4.x BSD.  The folks in the group that gave us System III
> and System V renamed them to strchr() and strrchr(), perhaps to avoid
> collisions; a number of UN*Xes offered them under both names, so that code
> written using either set of names would compile.  OS X may do so out of its
> BSD heritage, although I think for most if not all purposes it would
> suffice to declare them in <strings.h> but not in <string.h> (and not have
> <string.h> include <strings.h>).
Hi Guy,

Thanks for "historic" information...

May be add check (in checkAPI) for found there is no index (also time,
strlen) variable (and generate a warning)

Regards,


> ___________________________________________________________________________
> Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
> Archives:    http://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
>              mailto:wireshark-dev-request () wireshark org
> ?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe