Wireshark mailing list archives
Re: [Wireshark-commits] master 931807e: Qt: Add the "new packet" window^Wdialog^Wwindow.
From: Gerald Combs <gerald () wireshark org>
Date: Thu, 12 Feb 2015 19:31:14 -0800
On 2/12/15 5:44 PM, Guy Harris wrote:
On Feb 12, 2015, at 3:32 PM, Wireshark code review <code-review-do-not-reply () wireshark org> wrote:URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=931807ea61cd9b2729fa06fefa6ce3a09b89ee4b Submitter: Gerald Combs (gerald () wireshark org) Changed: branch: master Repository: wireshark Commits: 931807e by Gerald Combs (gerald () wireshark org): Qt: Add the "new packet" window^Wdialog^Wwindow. Allow persistence across files. Preserve the use of "window" even though we're really a dialog.So what's the difference between a "window" and a "dialog" here?
Ideally none. Creating a window with a standard buttons along the bottom using Qt Creator gives you a subclass of QDialog, which is why we have a lot of FooDialog classes in ui/qt. However, many (most?) of these should behave more like independent windows.
There's no minimize button, at least in OS X; is that intentional?
No. This should be fixed in g80342e4.
Presumably having double-clicking an item in the packet list not popping up a window is a Simple Matter of Programming not yet done, rather than intentional.
Fixed in ga0498f1. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] master 931807e: Qt: Add the "new packet" window^Wdialog^Wwindow. Guy Harris (Feb 12)
- Re: [Wireshark-commits] master 931807e: Qt: Add the "new packet" window^Wdialog^Wwindow. Gerald Combs (Feb 12)