Wireshark mailing list archives
Latest libnghttp2 checkin broken
From: Joerg Mayer <jmayer () loplof de>
Date: Fri, 1 May 2015 01:46:22 +0200
The latest checkin to libnghttp2 should not have happend: a) it breaks compilation on my system /home/jmayer/work/wireshark/git/epan/nghttp2/nghttp2_hd.c: In function ‘hd_inflate_remove_bufs_with_name’: /home/jmayer/work/wireshark/git/epan/nghttp2/nghttp2_hd.c:1736:10: error: variable ‘rv’ set but not used [-Werror=unused-but-set-variable] size_t rv; ^ and b) it can only have been committed with --no-verify as it contains deprecated functions (checkAPI.pl). I hit this during conflict resolution (git commit). Either we should remove the lib from the Wireshark source (an inconvenience as most distros don't provide packages for this) or the code needs to conform to Wireshark's development environment, i.e. it requires adaption and stricter testing than what seems to be happening right now. Ciao Jörg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: https://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Latest libnghttp2 checkin broken Joerg Mayer (Apr 30)