Wireshark mailing list archives
Re: [Wireshark-commits] master 7143bd7: Do the PCR and the original PCR the same way.
From: Alexis La Goutte <alexis.lagoutte () gmail com>
Date: Sat, 20 Sep 2014 17:48:10 +0200
On Mon, Sep 15, 2014 at 6:35 PM, Evan Huus <eapache () gmail com> wrote:
On Wed, Sep 10, 2014 at 5:16 PM, Martin Kaiser <lists () kaiser cx> wrote:Thanks for fixing this, I missed the buildbot error. Would there be any chance to include OS X in the petri dish? I tried this before pushing and saw no issues on Windows and Linux.It would be difficult because Amazon AWS does not provide mac instances, and we rely (partially) on that for security: if somebody petri-dishes a malicious change it can pretty easily take over that one machine at the moment.
What the warning ? because if it is 10.5 Mac os x buildbot... it is a old release of gcc/clang and i have not yet found how to get the same warning with a Linux box...
Thus wrote Wireshark code review (code-review-do-not-reply () wireshark org):URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7143bd72f9bc47f40f07763a9ef32459eaa5b311 Submitter: Guy Harris (guy () alum mit edu) Changed: branch: master Repository: wiresharkCommits:7143bd7 by Guy Harris (guy () alum mit edu):Do the PCR and the original PCR the same way.In both cases, make the extension a 16-bit variable, cast the result of extracting the extension to guint16 to clarify that only the 9 bits visible through the mask matter.While we're at it, there's no need to use "proto_tree_add_uint64_format_value() if the format is just the standard format for a 64-bit unsigned integer.Change-Id: I8f1f48595830d4672984f3797be1c9d994e64ea0 Reviewed-on: https://code.wireshark.org/review/4043 Reviewed-by: Guy Harris <guy () alum mit edu>Actions performed:from 4af01a8 don't skip another 6 bytes after OPCR Bug: 10446 adds 7143bd7 Do the PCR and the original PCR the same way.Summary of changes: epan/dissectors/packet-mp2t.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) ___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-request () wireshark org?subject=unsubscribe___________________________________________________________________________ Sent via: Wireshark-commits mailing list <wireshark-commits () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-commits Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits mailto:wireshark-commits-request () wireshark org?subject=unsubscribe___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] master 7143bd7: Do the PCR and the original PCR the same way. Evan Huus (Sep 15)
- Re: [Wireshark-commits] master 7143bd7: Do the PCR and the original PCR the same way. Alexis La Goutte (Sep 20)