Wireshark mailing list archives

Re: Patching as per checkAPI


From: Evan Huus <eapache () gmail com>
Date: Wed, 18 Jun 2014 00:40:07 -0700

If they're distinct changes on a single branch (so they're related, but
make sense as individual commits in the final repo) then #2. Gerrit might
warn you, but I think it will let you do it as long as you confirm you mean
it.

On Wed, Jun 18, 2014 at 12:35 AM, Dario Lombardo <
dario.lombardo.ml () gmail com> wrote:

I'm trying to taking care of some of the warnings from checkAPI. The
result is a set of commits.
What should I do now?

1) submit one push for every commit (eg. branch checkapi1, checkapi2, etc.)

2) submit one push with multiple commits (don't know if gerrit allows
it... I got an error when I tried to do so)

3) squash them into one commit (don't like it... the commits are
related to different APIs)

4) something else :)

Thanks for your help.
Dario.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org
?subject=unsubscribe

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: