Wireshark mailing list archives
Re: Gerrit Drafts
From: Michal Orynicz <michal.orynicz () tieto com>
Date: Fri, 13 Jun 2014 15:34:32 +0200
I'm using them already. The difference is that if You use [WIP], the commit is visible to everybody by default, and for draft it is visible only to the author and to reviewers. On 13 June 2014 15:30, Evan Huus <eapache () gmail com> wrote:
I was poking around gerrit a bit and I found an alternative way of handling WIP (work-in-progress) code. Apparently if you push to refs/drafts/BRANCH instead of refs/for/BRANCH (or alternatively pass -D to git-review) the review ends up in a special draft state that gerrit handles. Thoughts on using this instead of manual [WIP] tags? Openstack's wiki suggests not using it because it doesn't play well with their CI (test servers) but I don't know if that's an issue for us or not. Evan ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
-- Pozdrawiam / Best regards Michał Orynicz, Software Engineer Tieto Corporation Product Development Services http://www.tieto.com / http://www.tieto.pl --- ASCII: Michal Orynicz location: Swobodna 1 Street, 50-088 Wrocław, Poland room: 5.01 (desk next to 5.08) --- Please note: The information contained in this message may be legally privileged and confidential and protected from disclosure. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorised use, distribution or copying of this communication is strictly prohibited. If you have received this communication in error, please notify us immediately by replying to the message and deleting it from your computer. Thank You. --- Please consider the environment before printing this e-mail. --- Tieto Poland spółka z ograniczoną odpowiedzialnością z siedzibą w Szczecinie, ul. Malczewskiego 26. Zarejestrowana w Sądzie Rejonowym Szczecin-Centrum w Szczecinie, XIII Wydział Gospodarczy Krajowego Rejestru Sądowego pod numerem 0000124858. NIP: 8542085557. REGON: 812023656. Kapitał zakładowy: 4 271500 PLN
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Gerrit Drafts Evan Huus (Jun 13)
- Re: Gerrit Drafts Michal Orynicz (Jun 13)
- Re: Gerrit Drafts Alexis La Goutte (Jun 13)
- Re: Gerrit Drafts Gerald Combs (Jun 13)