Wireshark mailing list archives
Re: displaying header field without filtering
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Mon, 24 Feb 2014 16:34:21 -0500
On 02/21/14 14:42, Guy Harris wrote:
On Feb 21, 2014, at 8:15 AM, "John Dill" <John.Dill () greenfieldeng com> wrote:From the topic discussion, I got the impression that not putting hf_register_info entries for Spare or Reserved fields was considered bad practice.Some might consider it bad practice; I don't.
I'm one who has said it is bad practice. But... (more below)
The only advantage to having it be a named field would be to be able to filter for a specific value for the field, or to check whether it's non-zero. I'm not sure there's any point in filtering for specific values. There might be some use for checking for non-zero values *if* the spare bits are supposed to be zero; that's why I suggested proto_tree_add_mbz(), if, for a given collection of spare bits, those bits Must Be Zero.
That's true: in fact the only real use case I've had for it is filtering "xxx.yyy.spare != 0" because that helps me prove that implementation A is violating the law (which says the bits must be 0).
Personally I'd probably still err on the side of "add a [filterable] field for spare bytes" because I like to filter for them but there's no reason I couldn't do that and others could use these APIs.
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: displaying header field without filtering, (continued)
- Re: displaying header field without filtering Evan Huus (Feb 19)
- Re: displaying header field without filtering Guy Harris (Feb 19)
- duplicate field names (was: displaying header field without filtering) Hadriel Kaplan (Feb 20)
- Re: duplicate field names (was: displaying header field without filtering) Pascal Quantin (Feb 20)
- Re: duplicate field names (was: displaying header field without filtering) Hadriel Kaplan (Feb 20)
- Re: displaying header field without filtering Evan Huus (Feb 19)
- Re: displaying header field without filtering John Dill (Feb 20)
- Re: displaying header field without filtering Guy Harris (Feb 20)
- Re: displaying header field without filtering John Dill (Feb 21)
- Re: displaying header field without filtering Alexis La Goutte (Feb 21)
- Re: displaying header field without filtering Guy Harris (Feb 21)
- Re: displaying header field without filtering Jeff Morriss (Feb 24)
- Re: displaying header field without filtering John Dill (Feb 21)
- Re: displaying header field without filtering John Dill (Feb 24)