Wireshark mailing list archives
Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ...
From: Anders Broman <a.broman58 () gmail com>
Date: Sun, 14 Dec 2014 21:21:57 +0100
Den 14 dec 2014 21:03 skrev "Bill Meier" <wmeier () newsguy com>:
On 12/14/2014 2:22 PM, Stephen Fisher wrote:On Sun, Dec 14, 2014 at 01:44:19PM -0500, Bill Meier wrote:That being said, the convention (certainly not enforced) seems to be to use ENC_..._ENDIAN for fetching all integral types.Could this be related to when we made the change from using FALSE / TRUE to specify if its "big endian" in things like proto_tree_add_item() ?Good point ! fix-encoding-args.pl (used to do the change) just converted FALSE|0 to
BIG_ENDIAN and etc, so the "convention" actually kind-of-happened because previously TRUE|1 or FALSE|0 were the only choices for the 'encoding-arg".
So, I stand corrected. Maybe what I should be doing is converting all the single-byte fetches to
use ENC_NA.
Thoughts ? Bill
To me using the same endianess as beeing used for other integers in the dissector would make the most sense. Regards Anders
___________________________________________________________________________
Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Evan Huus (Dec 13)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Bill Meier (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Stephen Fisher (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Bill Meier (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Anders Broman (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Evan Huus (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Jeff Morriss (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Michal Labedzki (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Alexis La Goutte (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Graham Bloice (Dec 15)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Stephen Fisher (Dec 15)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Stephen Fisher (Dec 14)
- Re: [Wireshark-commits] master f412c9a: Use ENC_BIG_ENDIAN when fetching FT_U?INT8 fields ... Bill Meier (Dec 14)