Wireshark mailing list archives
Re: Change in wireshark[master]: Remove unneeded #includes from epan/dissectors
From: Bill Meier <wmeier () newsguy com>
Date: Fri, 19 Dec 2014 16:19:00 -0500
On 12/19/2014 12:05 PM, Martin Mathieson (Code Review) wrote:
Change subject: Remove unneeded #includes from epan/dissectors ...................................................................... Remove unneeded #includes from epan/dissectors
Martin: Obviously, #includes usage in dissectors is a bit of a mish-moshThere's one thing I would think worthwhile to do to try to keep the #includes a bit under control and somewhat consistent before going through the dissectors to remove unneeded #includes.
That is, I would change the dissectors as needed tohave '#include <epan/packet.h>' as the first #include (after config.h and any "system" includes).
If this is done, the #includes (direct and indirect) in packet.h can then be immediately removed from the dissectors.
Of the ~1130 non-generated .c files in epan/dissectors, there's about 350 which don't have '#include <epan/packet.h>' at all and maybe another 50 which don't have the include as the first wireshark include.
If you and others are Ok with this suggestion, I'd be happy to do that work (altho it might take me a day or three).
Bill ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: Change in wireshark[master]: Remove unneeded #includes from epan/dissectors Bill Meier (Dec 19)
- Re: Change in wireshark[master]: Remove unneeded #includes from epan/dissectors Martin Mathieson (Dec 19)
- Re: Change in wireshark[master]: Remove unneeded #includes from epan/dissectors Bill Meier (Dec 19)
- Re: Change in wireshark[master]: Remove unneeded #includes from epan/dissectors Bill Meier (Dec 20)