Wireshark mailing list archives
Re: Adding a new dissector - beginners guide
From: Graham Bloice <graham.bloice () trihedral com>
Date: Fri, 22 Aug 2014 15:05:21 +0100
On 22 August 2014 14:51, Thomas Wiens <th.wiens () gmx de> wrote:
Hi, I've just commited a fixed version. I think I did something wrong. In the review system it is shown as a new version. I used: git commit -a git review
As I noted on the review, I think you must have removed the Change-ID: line from the commit message that Gerrit uses to track a new patch set for an existing change. You should have used `git commit --amend` to commit and use the existing commit message. See the "Amending a change" section in http://wiki.wireshark.org/Development/SubmittingPatches To recover this, we can either consider the latest change as the "primary" change and abandon the older one (which would effectively throw away Bill's fine comments) or abandon the new change and resubmit your changes as a new patch set to the older change. -- Graham Bloice
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: Adding a new dissector - beginners guide, (continued)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 21)
- Re: Adding a new dissector - beginners guide Martin Kaiser (Aug 21)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 21)
- Re: Adding a new dissector - beginners guide Christopher Maynard (Aug 21)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 21)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 22)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 22)
- Re: Adding a new dissector - beginners guide Bill Meier (Aug 22)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 22)
- Re: Adding a new dissector - beginners guide Graham Bloice (Aug 22)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 22)
- Re: Adding a new dissector - beginners guide Bill Meier (Aug 22)
- Re: Adding a new dissector - beginners guide Thomas Wiens (Aug 23)
- Re: Adding a new dissector - beginners guide mmann78 (Aug 23)
- Re: Adding a new dissector - beginners guide Jeff Morriss (Aug 22)