Re: [Wireshark-commits] rev 52896: /trunk/ /trunk/ui/gtk/: main.c main_menubar.c /trunk/packaging/: Makefile.am /trunk/ui/qt/: main.cpp wireshark_application.cpp /trunk/: Makefile.nmake /trunk/ui/: recent.c ...

[Gerald Combs <gerald () wireshark org>]

On 10/28/13 5:10 PM, Jeff Morriss wrote:
> On 10/28/2013 06:13 PM, Gerald Combs wrote:
> > On 10/28/13 2:27 PM, Jeff Morriss wrote:
> > > On 10/27/13 13:15, gerald () wireshark org wrote:
> > > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52896
> > > >
> > > > User: gerald
> > > > Date: 2013/10/27 05:15 PM
> > > >
> > > > Log:
> > > >    Remove U3 code and packaging.
> > >
> > > There are still U3 references in epan/filesystem.c .  What, if anything,
> > > should be done wit those?
> >
> > I removed more references in r52935. WiresharkPortable.nsi sets a bunch
> > of U3 environment variables starting at line 218. Is there any reason
> > they shouldn't be removed as well?
>
> I can't remember what's the story with the various portable things.  I
> remember one of them was dead, I'm guessing that's U3.  If the others
> aren't dead but rely on the U3 base stuff (like filesystem.c) maybe
> whatever it is they rely on should be made more generic?

U3 is dead, but it looks like none of the 'U's U3 stand for 'unneeded'
or 'unnecessary'. The PortableApps package depends on the various U3_
environment variables so I reverted r52935 and parts of 52896.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe