Wireshark mailing list archives
Re: [Wireshark-commits] rev 52905: /trunk/epan/ /trunk/epan/: proto.c /trunk/epan/ftypes/: ftype-string.c
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Sun, 27 Oct 2013 18:41:22 -0400
On 10/27/2013 06:30 PM, Evan Huus wrote:
On Sun, Oct 27, 2013 at 5:56 PM, <morriss () wireshark org> wrote:http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=52905 User: morriss Date: 2013/10/27 09:56 PM Log: Fix https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=9323 : Actually handle non-NULL-terminated FT_STRINGs properly. Directory: /trunk/epan/ Changes Path Action +8 -8 proto.c Modified Directory: /trunk/epan/ftypes/ Changes Path Action +5 -3 ftype-string.c ModifiedThanks for your help tracking this one down. I think this accidentally introduces a leak for NULL strings though, because fvalue_set(&fi->value, (gpointer) g_strdup("[ Null ]"), FALSE); causes string_fvalue_set to take a second duplicate, leaking the first. Either set already_copied to TRUE or remove the g_strdup here.
<sigh>, thanks. Fixed. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 52905: /trunk/epan/ /trunk/epan/: proto.c /trunk/epan/ftypes/: ftype-string.c Evan Huus (Oct 27)
- Re: [Wireshark-commits] rev 52905: /trunk/epan/ /trunk/epan/: proto.c /trunk/epan/ftypes/: ftype-string.c Jeff Morriss (Oct 27)