Wireshark mailing list archives

Re: follow_stream_dialog.cpp warning turning error


From: Gerald Combs <gerald () wireshark org>
Date: Tue, 15 Oct 2013 08:24:11 -0700

On 10/14/13 10:18 PM, Joerg Mayer wrote:
[ 71%] Building CXX object ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o
/home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp: In member function ‘virtual void 
FollowStreamDialog::keyPressEvent(QKeyEvent*)’:
/home/jmayer/work/wireshark/svn/trunk/ui/qt/follow_stream_dialog.cpp:519:65: error: suggest parentheses around ‘&&’ 
within ‘||’ [-Werror=parentheses]
     if (event->key() == Qt::Key_F3 || event->key() == Qt::Key_N && event->modifiers() & Qt::ControlModifier) {
                                                                 ^
cc1plus: all warnings being treated as errors
make[2]: *** [ui/qt/CMakeFiles/qtui.dir/follow_stream_dialog.cpp.o] Error 1
make[1]: *** [ui/qt/CMakeFiles/qtui.dir/all] Error 2

Fixed in r52620.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: