Wireshark mailing list archives
Re: Wireshark PIDL generated dissectors
From: mmann78 () netscape net
Date: Mon, 4 Nov 2013 08:25:40 -0500 (EST)
The issue is that Windows treats the guint3264 datatype as a 64-bit value and warns (which gets treated as errors) about the downgrade to a 32-bit value when passing "size" into tvb_new_subset() and when doing the addition to "offset". Just a simple cast in both places is enough. -----Original Message----- From: Matthieu Patou <mat () samba org> To: mmann78 <mmann78 () netscape net>; wireshark-dev <wireshark-dev () wireshark org> Cc: abartlet <abartlet () samba org>; samba-technical <samba-technical () samba org> Sent: Mon, Nov 4, 2013 3:25 am Subject: Re: [Wireshark-dev] Wireshark PIDL generated dissectors On 11/03/2013 08:26 AM, mmann78 () netscape net wrote:
Matthieu, I committed 0010-frsrpc-Regenerate-frsrpc-due-to-changes-in-the-pidl-.patch
and 0016-Regenerate-the-dnserver.patch with the necessary changes to get it to compile on Windows to r53067. As the commit message mentions, I think the PIDL generator may need to be updated in order for dissectors to compile on Windows.
Which changes are needed ? It shouldn't be too hard to ask politely pidl to generate compatible code as long as I know what we have to generate. Matthieu -- Matthieu Patou Samba Team http://samba.org
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: Wireshark PIDL generated dissectors mmann78 (Nov 03)
- Re: Wireshark PIDL generated dissectors Pascal Quantin (Nov 03)
- Re: Wireshark PIDL generated dissectors Matthieu Patou (Nov 04)
- Re: Wireshark PIDL generated dissectors Pascal Quantin (Nov 04)
- Re: Wireshark PIDL generated dissectors Matthieu Patou (Nov 04)
- Re: Wireshark PIDL generated dissectors Matthieu Patou (Nov 04)
- Re: Wireshark PIDL generated dissectors mmann78 (Nov 04)
- Re: Wireshark PIDL generated dissectors Pascal Quantin (Nov 03)