Wireshark mailing list archives
Re: offset incrementation in packet-ssl.c (was: r53416: Add status_request_v2 TLS extension dissection (RFC6961))
From: Alexis La Goutte <alexis.lagoutte () gmail com>
Date: Wed, 20 Nov 2013 19:42:14 +0100
Hi Jakub, Thank for the catching ! Fix in revision 53444 Regards, On Wed, Nov 20, 2013 at 12:08 AM, Jakub Zawadzki <darkjames-ws () darkjames pl>wrote:
Hello Alexis, Peter, Looking at r53416 [1] diff, I found two things in packet-ssl.c strange 2861 dissect_ssl3_hnd_hello_ext_status_request_v2(tvbuff_t *tvb, proto_tree *tree, 2869 while (list_len-- > 0) 2870 offset += dissect_ssl3_hnd_hello_ext_status_request(tvb, tree, offset, TRUE); // but dissect_ssl3_ocsp_response() return offset not delta. 3929 dissect_ssl3_hnd_cert_status(tvbuff_t *tvb, proto_tree *tree, 3950 while (list_len-- > 0) 3951 offset += dissect_ssl3_ocsp_response(tvb, tree, offset, pinfo); // but dissect_ssl3_ocsp_response() return offset not delta. I think in both cases it should be '=' not '+=' Could you please check it? Thanks, Kuba. [1] http://code.wireshark.org/git/?p=wireshark;a=commitdiff;h=123e3d92039770c0a36c4be97ae34c1ef27c4f8e ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org ?subject=unsubscribe
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- offset incrementation in packet-ssl.c (was: r53416: Add status_request_v2 TLS extension dissection (RFC6961)) Jakub Zawadzki (Nov 19)
- <Possible follow-ups>
- Re: offset incrementation in packet-ssl.c (was: r53416: Add status_request_v2 TLS extension dissection (RFC6961)) Alexis La Goutte (Nov 20)