Re: [Wireshark-commits] rev 49380: /trunk-1.8/ /trunk-1.8/epan/dissectors/: packet-amr.c packet-tcp.c /trunk-1.8/docbook/: release-notes.xml /trunk-1.8/epan/: tvbuff.c

[Jeff Morriss <jeff.morriss.ws () gmail com>]

On 05/17/13 12:37, Evan Huus wrote:
> On Fri, May 17, 2013 at 12:20 PM, <gerald () wireshark org
> <mailto:gerald () wireshark org>> wrote:
>
>
>       ------------------------------------------------------------------------
>         r49379 | morriss | 2013-05-17 07:38:36 -0700 (Fri, 17 May 2013)
>     | 7 lines
>         Changed paths:
>            M /trunk/epan/tvbuff.c
>
>         As suggested by Jakub: don't ep_alloc buffers for TVBs, use
>     g_malloc()'d
>         memory with tvb-free-callback.
>
>         Fixes one of the "read after free" warnings from Valgrind
>     reported in
>     https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8197 and the one
>     reported
>         in https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=8653
>
>       ------------------------------------------------------------------------
>
>
> I don't think this one was necessary in 1.8, since it doesn't have
> Jakub's work on shrinking the ep scope that I remember, but it won't hurt.

Oops, yeah, that's a good point.  But, you're also right that it 
certainly won't hurt.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe