Wireshark mailing list archives
Re: cleanup_dissection() called both on cf_close and cf_open()
From: Gerald Combs <gerald () wireshark org>
Date: Mon, 25 Mar 2013 12:37:15 -0700
On 3/24/13 7:37 AM, Anders Broman wrote:
Hi, Looking into address resolution I found that the hosts file is read multiple times partly because it's part of cleanup_dissection() which is called both on cf_open() and cf_close(). Should cleanup_dissection() take an argument showing whether its a file open or file close operation and different measures taken at least when it comes to the host_name_lockup...?
This is partly my fault, resulting from switching to seasonal memory for name resolution in r45511. We call se_free_all() a lot, which means calling host_name_lookup_init() a lot. It might be better to use a different allocator for resolved addresses or to delay reading any hosts files somehow. Either way we need to make sure resolved addresses don't leak from one capture to the next. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- cleanup_dissection() called both on cf_close and cf_open() Anders Broman (Mar 24)
- Re: cleanup_dissection() called both on cf_close and cf_open() Evan Huus (Mar 24)
- Re: cleanup_dissection() called both on cf_close and cf_open() Gerald Combs (Mar 25)
- Re: cleanup_dissection() called both on cf_close and cf_open() Evan Huus (Mar 25)