Wireshark mailing list archives

Re: [Wireshark-commits] rev 50798: /trunk/wiretap/ /trunk/wiretap/: CMakeLists.txt


From: Joerg Mayer <jmayer () loplof de>
Date: Tue, 23 Jul 2013 11:50:59 +0200

On Mon, Jul 22, 2013 at 04:43:44PM -0700, Guy Harris wrote:
On UN*X (which I'm assuming it is), ws_lseek64() is #defined as lseek:

      #define ws_lseek64 lseek /* AC_SYS_LARGEFILE should make off_t 64-bit */

and, as the comment notes, we *should* be building with whatever flags etc. cause the "Large File Summit" features to 
be enabled, so that lseek()'s second argument is a signed 64-bit integer.

As "AC_SYS_LARGEFILE" implies, the "flags etc." are being set by AC_SYS_LARGEFILE when using autotools.  We need to 
do whatever the CMake equivalent of "please turn large file support on" is; if we're already doing that, it appears 
not to be working.  (I infer from "'gint64' (aka 'long long')" that this is a 32-bit build, and the 32-bit platforms 
are the ones where Large File Summit hackery is needed to support Large Files - well, except for 4.4-Lite-derived 
32-bit platforms, where off_t is *always* 64-bit.)

Thanks to your advice the problem should be properly fixed now.

 Jörg
-- 
Joerg Mayer                                           <jmayer () loplof de>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Current thread: