Re: RFC: new types for hfi->display (STR_ASCII, STR_UNICODE), drop proto_tree_add_unicode_string()

[Pascal Quantin <pascal.quantin () gmail com>]

2013/12/7 Jakub Zawadzki <darkjames-ws () darkjames pl>

> Hi,
>
> I renamed base_display_e to field_display_e, and added new enums to
> field_display_e,
> but I wonder if it's correct approach.
>
> For FT_ABSOLUTE_TIME we're using seperate enum
> (absolute_time_display_e), so maybe FT_STRING* should also have own enum
> string_display_e ?
>
>
> Anyway, dissecotrs using proto_tree_add_unicode_string():
>         packet-gsm_sms.c
>         packet-etsi_card_app_toolkit.c
>         packet-rrc.c
>         packet-ptpip.c
>         packet-lte-rrc.c
>         packet-gmr1_rr.c
>         packet-ansi_637.c
>
> Should probably change it back to proto_tree_add_item/
> proto_tree_add_string and start using STR_UNICODE display.
> If you need some extra flag like: STR_UNICODE_DONT_ESCAPE than go on.

Hi Jakub,

I changed them in r53867, updated README.dissector a bit in r53868 and
removed proto_tree_add_unicode_string() in r53869.

Regards,
Pascal.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe