Re: [Wireshark-bugs] [Bug 5284] new_packet_list: redissection + redraw crashes when multi-data-source packet is selected

[Evan Huus <eapache () gmail com>]

On Mon, Oct 8, 2012 at 2:37 PM, Pascal Quantin <pascal.quantin () gmail com> wrote:
> Hi Evan,
>
> 2012/10/8 <bugzilla-daemon () wireshark org>
> > https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=5284
> >
> > Evan Huus <eapache () gmail com> changed:
> >
> >            What    |Removed                     |Added
> >
> > ----------------------------------------------------------------------------
> >              Status|NEW                         |RESOLVED
> >          Resolution|                            |FIXED
> >
> > --- Comment #28 from Evan Huus <eapache () gmail com> 2012-10-08 08:26:16 PDT
> > ---
> > The last little bits of this have finally been properly fixed in rev
> > 45389. New
> > bugs with that code are new bugs, as this one is getting rather unwieldy
> > :)
>
>
> Now when compiling with gcc-4.3.2 on my old Debian Lenny, I get:
> make[3]: Entering directory `/home/pascal/soft/wireshark/trunk/epan'
> /bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..
> -I./.. -I./../tools/lemon -I./wslua       -DINET6 -DG_DISABLE_DEPRECATED
> -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_DEPRECATED
> -DGTK_DISABLE_SINGLE_INCLUDES  -D_FORTIFY_SOURCE=2 -I/usr/local/include -I
> /home/pascal/soft/include
> '-DPLUGIN_DIR="/usr/local/lib/wireshark/plugins/1.9.0"' -Werror -DPYTHONDIR=
> -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels
> -Wpointer-arith -Wno-pointer-sign -Warray-bounds -Wcast-align
> -Wformat-security -Wold-style-definition -D_REENTRANT -I/usr/include/gtk-2.0
> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
> -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12
> -I/usr/include/pixman-1   -MT libwireshark_la-emem.lo -MD -MP -MF
> .deps/libwireshark_la-emem.Tpo -c -o libwireshark_la-emem.lo `test -f
> 'emem.c' || echo './'`emem.c
>  gcc -DHAVE_CONFIG_H -I. -I.. -I./.. -I./../tools/lemon -I./wslua -DINET6
> -DG_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_DEPRECATED
> -DGTK_DISABLE_SINGLE_INCLUDES -D_FORTIFY_SOURCE=2 -I/usr/local/include -I
> /home/pascal/soft/include
> -DPLUGIN_DIR=\"/usr/local/lib/wireshark/plugins/1.9.0\" -Werror -DPYTHONDIR=
> -g -O2 -Wall -W -Wextra -Wdeclaration-after-statement -Wendif-labels
> -Wpointer-arith -Wno-pointer-sign -Warray-bounds -Wcast-align
> -Wformat-security -Wold-style-definition -D_REENTRANT -I/usr/include/gtk-2.0
> -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo
> -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
> -I/usr/include/freetype2 -I/usr/include/directfb -I/usr/include/libpng12
> -I/usr/include/pixman-1 -MT libwireshark_la-emem.lo -MD -MP -MF
> .deps/libwireshark_la-emem.Tpo -c emem.c  -fPIC -DPIC -o
> .libs/libwireshark_la-emem.o
> emem.c:153: error: redefinition of typedef ‘emem_header_t’
> ftypes/../emem.h:37: error: previous declaration of ‘emem_header_t’ was here
> make[3]: *** [libwireshark_la-emem.lo] Error 1
> make[3]: Leaving directory `/home/pascal/soft/wireshark/trunk/epan'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/home/pascal/soft/wireshark/trunk/epan'
> make[1]: *** [all-recursive] Error 1
> make[1]: Leaving directory `/home/pascal/soft/wireshark/trunk'
> make: *** [all] Error 2
>
> I do not have the time to look at it right now, so if you have some spare
> time feel free :)

I believe Gerald already caught this in revision 45396

https://anonsvn.wireshark.org/viewvc?view=revision&revision=45396

Evan
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe