Wireshark mailing list archives
Logical error in r37159
From: Sean Bright <sean.bright () gmail com>
Date: Thu, 09 Feb 2012 18:20:22 -0500
In r37159, the following change was made to ui/gtk/rtp_player.c: @@ -1654,9 +1636,7 @@ GtkWidget *dialog; /* we should never be here if we are in PLAY and !PAUSE */ - if(!rtp_channels->stop&& !rtp_channels->pause){ - exit(10); - } + g_assert(!rtp_channels->stop&& !rtp_channels->pause); The logic, however, was not negated properly. The correct assertion should be: g_assert(rtp_channels->stop || rtp_channels->pause); With the current code, the RTP player causes a crash for me when pressing the 'Play' button. Thanks, Sean Bright
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Logical error in r37159 Sean Bright (Feb 09)
- Re: Logical error in r37159 Joerg Mayer (Feb 09)