Re: filters name : gmr1_xxx vs gmr1.xxx

[Anders Broman <anders.broman () ericsson com>]

Hi,
> So far I had named the filters in the field definition like gmr1.bcch.xxx  or gmr1.rr.xxx ...
Looks reasonable to me.
Regards
Anders
-----Original Message-----
From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Sylvain Munaut
Sent: den 5 februari 2012 21:10
To: Developer support list for Wireshark
Subject: [Wireshark-dev] filters name : gmr1_xxx vs gmr1.xxx

Hi,

I'm about to submit GMR-1 dissectors and when running them through the checkfiltername script, it warns me about the 
name I chose.

Since GMR-1 has different channel types with completely different messages (and messages encoding), there is several 
packet-xxx:

packet-gmr1_dtap.c
packet-gmr1_rr.c
packet-gmr1_common.c
packet-gmr1_bcch.c

So far I had named the filters in the field definition like gmr1.bcch.xxx  or gmr1.rr.xxx ...

Is that acceptable or should I really stick to starting the filters by what's after the 'packet-' filename ?

Cheers,

    Sylvain
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe