Wireshark mailing list archives
Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c
From: Anders Broman <anders.broman () ericsson com>
Date: Wed, 8 Aug 2012 11:46:06 +0200
-----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Joerg Mayer Sent: den 8 augusti 2012 11:29 To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c On Wed, Aug 08, 2012 at 09:32:06AM +0200, Anders Broman wrote:
Or graph_utils.c
Sure
Io_graph.c rtp_analysis.c and iax_analysis.c is very similar and there's the same problem of sharing code.I just did a s/rtp/NAME/g in rtp_analysis.c and s/iax2/NAME/g in iax2_analysis.c and then a diff -uwbB iax2_name rtp_name. The similarities are striking - it really looks like these files are more than 80% identical. The same for io_stat.c didn't (syntactically) look that identical.
I think io_graph-c is the original Rtp_analysis.c copies the graph part from io_garph.c but contains other code as well. Iax_analysis.c is a Derivate of rtp_analysis.c Ideally the graph code should be shared by all, and iax. And rtp share the other common code. -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Joerg Mayer (Aug 07)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Martin Mathieson (Aug 07)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Joerg Mayer (Aug 08)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Anders Broman (Aug 08)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Joerg Mayer (Aug 08)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Anders Broman (Aug 08)
- Unifying graphics Joerg Mayer (Aug 08)
- Re: Unifying graphics Guy Harris (Aug 08)
- Re: Unifying graphics Jakub Zawadzki (Aug 12)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Joerg Mayer (Aug 08)
- Re: [Wireshark-commits] rev 44316: /trunk/ui/gtk/ /trunk/ui/gtk/: tcp_graph.c Martin Mathieson (Aug 07)