Wireshark mailing list archives
Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c
From: Sylvain Munaut <246tnt () gmail com>
Date: Sun, 19 Aug 2012 12:40:06 +0200
Hi, I've just seen those changes (filter names) now and I'm really not happy with them ... 1) I explicitely asked this list for objections against the gmr1.xx vs gmr1_xx name and I was told that using gmr1.xx made sense given it's always the same protocol. And nobody expressed any view against it and Andrew said it was a reasonable choice. Now all saved filters / examples / ...would have to be changed for really no good reason. 2) I would really appreciate if the author of the dissector was at least CC'ed when doing changes to the dissector ... This is not the first time and in every instance, the original commit had to be followed by "fixups" commits because the patch author seemed to be more concerned with removing warnings at all costs than actually doing the right fix ... Cheers, Sylvain ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c Sylvain Munaut (Aug 19)
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c Pascal Quantin (Aug 19)
- <Possible follow-ups>
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c mmann78 (Aug 19)
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c Pascal Quantin (Aug 21)
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c mmann78 (Aug 21)
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c Sylvain Munaut (Aug 22)
- Re: Wireshark-commits: [Wireshark-commits] rev 44161: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-gmr1_bcch.c packet-gmr1_common.c packet-gmr1_rr.c Pascal Quantin (Aug 21)