Re: [Wireshark-commits] rev 44380: /trunk/epan/ /trunk/epan/: emem.c

[mmann78 () netscape net]

Does this patch help?  If not, I would consider blaming guids_add_guid for not initializing the key member of the 
emem_tree_key_t structure.  Even though I think either would be caught by the DISSECTOR_ASSERT_NOT_REACHED macro. Also, 
are there warning for emem_tree_lookup32_array() as well?


-----Original Message-----
From: Jeff Morriss <jeff.morriss.ws () gmail com>
To: wireshark-dev <wireshark-dev () wireshark org>
Sent: Thu, Aug 9, 2012 4:06 pm
Subject: Re: [Wireshark-dev] [Wireshark-commits] rev 44380: /trunk/epan/ /trunk/epan/: emem.c


mmann () wireshark org wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=44380
>
> User: mmann
> Date: 2012/08/09 06:59 AM
>
> Log:
>  Make emem_tree_*32_array functions non-destructive.

With this change Valgrind issues many, many warnings as Wireshark starts:

==10126== Conditional jump or move depends on uninitialised value(s)
==10126==    at 0x6071DEF: emem_tree_insert32_array (emem.c:1887)
==10126==    by 0x607874E: guids_add_guid (guid-utils.c:117)
==10126==    by 0x62638CE: dcerpc_init_uuid (packet-dcerpc.c:830)
==10126==    by 0x69E3061: register_all_protocol_handoffs (register.c:1360)
==10126==    by 0x6085CA2: proto_init (proto.c:401)
==10126==    by 0x6073565: epan_init (epan.c:113)
==10126==    by 0x418AE5: main (tshark.c:963)
==10126==
==10126== More than 100 errors detected.  Subsequent errors
==10126== will still be recorded, but in less detail than before.

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe

Attachment: emem.c.patch
Description:

___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe