Wireshark mailing list archives
Re: [Wireshark-commits] rev 36988: /trunk/ /trunk/epan/dissectors/: packet-iwarp-mpa.c packet-spnego.c packet-ssl-utils.c /trunk/: tap-iostat.c
From: Jeff Morriss <jeff.morriss.ws () gmail com>
Date: Thu, 05 May 2011 09:27:40 -0400
Jakub Zawadzki wrote:
On Wed, May 04, 2011 at 04:40:12PM -0600, Stephen Fisher wrote:On Wed, May 04, 2011 at 09:19:08PM +0000, darkjames () wireshark org wrote:is that inside GTK+ and GLib, they still use g_malloc, so we can't totally eliminate the possibilty of Wireshark being aborted when out of memory.Log: XXX, should this code use g_try_malloc instead?Hmm, we could set our own allocator (g_mem_set_vtable()), and THROW OutOfMemoryError (instead of aborting) for example vtab.malloc routine: #v+ static gpointer ws_malloc(gsize n_bytes) { gpointer ptr = malloc(n_bytes); if (!ptr) THROW(OutOfMemoryError); return ptr; } #v-
Is it likely/possible that: a) GTK (or glib) might acquire a lock before allocating something b) (and) we might call another GTK function which requires the same lock thus leading to a deadlock if we jump out of the allocation failure? ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 36988: /trunk/ /trunk/epan/dissectors/: packet-iwarp-mpa.c packet-spnego.c packet-ssl-utils.c /trunk/: tap-iostat.c Stephen Fisher (May 04)
- Re: [Wireshark-commits] rev 36988: /trunk/ /trunk/epan/dissectors/: packet-iwarp-mpa.c packet-spnego.c packet-ssl-utils.c /trunk/: tap-iostat.c Jakub Zawadzki (May 04)
- Re: [Wireshark-commits] rev 36988: /trunk/ /trunk/epan/dissectors/: packet-iwarp-mpa.c packet-spnego.c packet-ssl-utils.c /trunk/: tap-iostat.c Jeff Morriss (May 05)
- Re: [Wireshark-commits] rev 36988: /trunk/ /trunk/epan/dissectors/: packet-iwarp-mpa.c packet-spnego.c packet-ssl-utils.c /trunk/: tap-iostat.c Jakub Zawadzki (May 04)