Re: About Dead Store in clang Analysis

[Jeff Morriss <jeff.morriss.ws () gmail com>]

Chris Maynard wrote:
> Alexis La Goutte <alexis.lagoutte@...> writes:
>
> > What it the official solution to fix this ?
> > 1) Remove the code 
> > 2) Ignore this warning 
> > 3) Comment the code  add a 
> >  /*     offset += 1;  Remove Clang Dead increment */
>
> Or ... convert the dissector to a "new-style" dissector where the number of
> bytes it consumes is returned, and in that case the offset should be incremented
> but will need to be returned from any functions so proper offset (and thus the
> proper number of bytes consumed) can be maintained and eventually returned from
> the dissector.

+1 :-)
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
            mailto:wireshark-dev-request () wireshark org?subject=unsubscribe