Wireshark mailing list archives
Re: [Wireshark-commits] rev 38782: /trunk/gtk/ /trunk/gtk/: main_menubar.c stock_icons.c
From: Joerg Mayer <jmayer () loplof de>
Date: Mon, 29 Aug 2011 22:37:30 +0200
On Mon, Aug 29, 2011 at 10:09:01PM +0200, Joerg Mayer wrote:
On Mon, Aug 29, 2011 at 07:47:53PM +0000, sfisher () wireshark org wrote:http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=38782 User: sfisher Date: 2011/08/29 12:47 PM Log: Fix compilation when compiling without libpcap (configure script parameter "--without-pcap")...Changes Path Action +6 -2 main_menubar.c Modified +6 -0 stock_icons.c ModifiedAdding back to #ifdef HAVE_LIBPCAP is not the nicest way. We have way too many places with #ifdef somethingorother. IIRC the intention of the patch that caused the problem was to always have all features in the menu, some of them just not visible/selectable(?).
Something like the attached patch - compile tested only! ciao Joerg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.
Attachment:
alternative.patch
Description:
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 38782: /trunk/gtk/ /trunk/gtk/: main_menubar.c stock_icons.c Joerg Mayer (Aug 29)
- Re: [Wireshark-commits] rev 38782: /trunk/gtk/ /trunk/gtk/: main_menubar.c stock_icons.c Joerg Mayer (Aug 29)
- Re: [Wireshark-commits] rev 38782: /trunk/gtk/ /trunk/gtk/: main_menubar.c stock_icons.c Guy Harris (Aug 29)
- Re: [Wireshark-commits] rev 38782: /trunk/gtk/ /trunk/gtk/: main_menubar.c stock_icons.c Anders Broman (Aug 29)