Re: [Wireshark-commits] rev 36772: /trunk/plugins/profinet/ /trunk/plugins/profinet/: packet-dcerpc-pn-io.c

[Stig Bjørlykke <stig () bjorlykke org>]

On Thu, Apr 21, 2011 at 6:01 PM,  <alagoutte () wireshark org> wrote:
>  Fix Dead Store (Dead assignement/Dead increment) Warning found by Clang

-    flags1_tree = proto_item_add_subtree(flags1_item,
ett_pn_io_profisafe_f_parameter_prm_flag1);
+    proto_item_add_subtree(flags1_item,
ett_pn_io_profisafe_f_parameter_prm_flag1);

This fix is completely wrong!

You have no need for a proto_item_add_subtree without using the return value.
In this case I suppose flags1_tree should be use in the next
dissect_dcerpc_uint8 calls instead of using flags1_item.


-- 
Stig Bjørlykke
___________________________________________________________________________
Sent via:    Wireshark-dev mailing list <wireshark-dev () wireshark org>
Archives:    http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-request () wireshark org?subject=unsubscribe