Wireshark mailing list archives
Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c
From: Sake Blok <sake () euronet nl>
Date: Mon, 4 Oct 2010 00:45:19 +0200
On 3 okt 2010, at 23:48, Guy Harris wrote:
On Oct 3, 2010, at 12:44 PM, Sake Blok wrote:On 3 okt 2010, at 20:18, Guy Harris wrote:Where is it failing?It was failing in both "capture_filter_compile_cb" and "dumpcap.c", the only places where bpf_image is used. As long as HAVE_BPF_IMAGE is not defined, all is fine (except, the compile BPF button is not available and neither is dumpcap -d). But if I "add support for" bpf_image in the same way as I added support for pcap_open_dead, the linker complains that bpf_image can not be found.That's because, at least in the current top of tree, the bpf_image() wrapper in capture-wpcap.c is static. None of the other wrappers are.
Oops! Thanks for spotting that. It now works on my WinXP-dev-VM... checking it in... Cheers, Sake ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Bill Meier (Oct 02)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Bill Meier (Oct 02)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Sake Blok (Oct 02)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Guy Harris (Oct 02)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Sake Blok (Oct 03)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Guy Harris (Oct 03)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Sake Blok (Oct 03)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Guy Harris (Oct 03)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Sake Blok (Oct 03)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Stig Bjørlykke (Oct 04)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Sake Blok (Oct 02)
- Re: [Wireshark-commits] rev 34339: /trunk/gtk/ /trunk/gtk/: capture_dlg.c Bill Meier (Oct 02)