Wireshark mailing list archives
Re: Dissector bug
From: philippe alarcon <philippe.alarcon () live fr>
Date: Fri, 8 Jan 2010 23:43:46 +0100
Hello, Some additional information regarding the comments made by Chris : - effectively some fields are duplicated in hf_oqtp[] array. (removed in the attached version) - the warnings "Not terminated: value string" are due that the refered arrays are ended with a comma with no element after. (commas removed in the attached version) apart from this : - it appears that in hf_oqtp[] you cannot use FT_STRING, and BASE_CUSTOM. I have replaced BASE_CUSTOM by BASE_NONE which is dedicated to text. But I cannot explain why BASE_CUSTOM cannot be used in this case. (replaced in the attached version) - you have registered several subtrees. But ett_msg_fragment and ett_msg_fragments elements were refered in each subtree. Then Wireshark raises an error as it detects that the same elements have been defined many times. (moved as comments in the attached version) Find attached a modified version of your dissector that is loaded correctly with Wireshark 1.3.3. Then in order to validate the dissector, it would be helpful to have a record with packets conformed to this protocol. I hope this will help you. Regards Philippe
Date: Fri, 8 Jan 2010 12:08:42 -0500 From: Christopher.Maynard () GTECH COM To: wireshark-dev () wireshark org Subject: Re: [Wireshark-dev] Dissector bug I ran checkhf.pl on packet-dash.c, but it didn't pick up the duplicates, only the following: Unused entry: ../../packet-dash.c, hf_description_len Unused entry: ../../packet-dash.c, hf_oqtp_reserved Unused entry: ../../packet-dash.c, hf_reserved_bits However, I also just ran checkAPIs.pl on it, which found the following, more egregious problems: Warning: ../../packet-dash.c does not have an SVN Id tag. Error: Found C++ style comments in ../../packet-dash.c Error: ../../packet-dash.c : Not terminated: value_string group_type_coding[] Error: ../../packet-dash.c : Not terminated: value_string group_sub_type_coding[] Error: ../../packet-dash.c : Not terminated: value_string primary_assets_flag_coding[] Error: ../../packet-dash.c : Not terminated: value_string asset_type_coding[] Error: ../../packet-dash.c : Not terminated: value_string direction_field_coding[] Error: ../../packet-dash.c : Not terminated: value_string sub_coding[] Error: ../../packet-dash.c : Not terminated: value_string ippv_coding[] Error: ../../packet-dash.c : Not terminated: value_string oppv_coding[] Error: ../../packet-dash.c : Not terminated: value_string request_satisfied_coding[] Error: ../../packet-dash.c : Not terminated: value_string no_extended_pd_syntax_coding[] Error: ../../packet-dash.c : Not terminated: value_string sort_order_type_coding[] Error: ../../packet-dash.c : Not terminated: value_string no_locator_flag_coding[] Error: ../../packet-dash.c : Not terminated: value_string search_type_coding[] Error: ../../packet-dash.c : Not terminated: value_string asset_types_coding[] Error: Found prohibited APIs in ../../packet-dash.c: malloc,free - Chris -----Original Message----- From: wireshark-dev-bounces () wireshark org [mailto:wireshark-dev-bounces () wireshark org] On Behalf Of Joerg Mayer Sent: Friday, January 08, 2010 11:34 AM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Dissector bug On Fri, Jan 08, 2010 at 11:39:04AM +0530, Rach, Darshan wrote:I am getting the following error: [Dissector bug, protocol DASH: proto.c:2457: failed assertion"(guint)hfindex < gpa_hfinfo.len"]My code looks like this: static gint hf_epg_info_bits_len = -1; {&hf_epg_info_bits_len, {"EPG Info Bits Length","oqtp.epg_info_bits_len",FT_UINT8,BASE_DEC,NULL, 0x0,"EPG Info Bits Length", HFILL}}, epg_info_bits_len = ((tvb_get_guint8(next_tvb, packet_field_offset)) &0xf);proto_tree_add_uint(sub_tree, hf_epg_info_bits_len, next_tvb,packet_field_offset, 1, epg_info_bits_len);packet_field_offset += 1;Had similar problems of a similar type. Please run tolls/checkhf.pl on your dissector source. Ciao Joerg -- Joerg Mayer <jmayer () loplof de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology. ________________________________________________________________________ ___ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe CONFIDENTIALITY NOTICE: The contents of this email are confidential and for the exclusive use of the intended recipient. If you receive this email in error, please delete it from your system immediately and notify us either by email, telephone or fax. You should not copy, forward, or otherwise disclose the content of the email. ___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
_________________________________________________________________ Tchattez en direct en en vidéo avec vos amis ! http://www.windowslive.fr/messenger/
Attachment:
packet-dash.c
Description:
___________________________________________________________________________ Sent via: Wireshark-dev mailing list <wireshark-dev () wireshark org> Archives: http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev mailto:wireshark-dev-request () wireshark org?subject=unsubscribe
Current thread:
- Dissector bug Rach, Darshan (Jan 07)
- Re: Dissector bug Jan Gerbecks (Jan 08)
- Re: Dissector bug Rach, Darshan (Jan 08)
- Re: Dissector bug Rach, Darshan (Jan 08)
- Re: Dissector bug Maynard, Chris (Jan 08)
- Re: Dissector bug Joerg Mayer (Jan 08)
- Re: Dissector bug Maynard, Chris (Jan 08)
- Re: Dissector bug philippe alarcon (Jan 08)
- Re: Dissector bug Maynard, Chris (Jan 09)
- Re: Dissector bug Stephen Fisher (Jan 12)
- Re: Dissector bug Maynard, Chris (Jan 08)
- Re: Dissector bug Jan Gerbecks (Jan 08)